Repository navigation
Fix 6D Settings Parsing for Versions Below 1.21 - #130
Merged
Merged
Conversation
Contributor
Author
|
@Capelliexp I was hesitant to add the tests because I think they are likely overkill. I kept them for the initial draft, to give you a chance to weigh in. |
Contributor
Author
|
Spoke with @Capelliexp and we're ignoring the windows build failure caused by doctest and is unrelated to this change. |
Capelliexp
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Read6DOFSettingsalways failed against the pre-1.21 XML format, so clients pinned below 1.21 (e.g. QTM Connect for MATLAB at 1.17) got no 6DOF bodies. Regression from the tinyxml2 rewrite (#109).Problem
In the legacy branch of
Deserialize6DOFSettings:BodiesandBodywere looked up on the document root instead of insideThe_6D(returned false immediately)TryReadSetPointsOlditeratedBoneelements (previouslyPoint)TryReadSetEulerran once per body and treated a missing<Euler>as an errordataAvailablewas only set when at least one body was foundSolution
The_6D, readPointelements, readEuleronce after the body loop and treat it as optional (complete or absent)dataAvailablefor the element rather than per bodyRead6DOFSettingsnow sets an error string naming the protocol version on parse failureTests Run