Quam builder cavity

[MichalGQM]

adding components for 3D cavity

[OziEgri]

@MichalGQM structure wise it looks fine, but would be great if @Deepakkhurrana can take another look.
In the future let's try to make all PRs bite-size, really hard to review PR of 100s of lines

[MichalGQM]

Ok! added @Deepakkhurrana as a reviewer.

[Deepakkhurrana]

I would like to have bit more context here. Seems like the PR is for creating placeholders across for a new cavity quam object as there is lot of code repetition and it looks like a transmon object to me at this point. I guess the idea is to make subsequent PRs to upgrade the classes to make it specific to the cavity?

[MichalGQM]

Hi @Deepakkhurrana , yes the idea is to create the components needs for the cavity with minimal changes. I added the cavity folder to quam_builder/architecture/superconducting/.

[Deepakkhurrana]

LGTM for now. However I do want to flag the copy of the all the transmon specific properties into cavity module as a potential maintenance risk. This introduces a fair amount of duplication that could drift over time if not consolidated.

Instead, it might be cleaner to start with a minimal cavity object and incrementally add cavity-specific functionality in follow-up PRs, rather than copying the full qubit structure upfront.

[MichalGQM]

I agree. I have a meeting with a customer about it next week. I can show him this quam and discuss with him what are the necessary things for them, so we can have the minimal necessary things and then push it to main. How does that sound?