Merged
Conversation
Collaborator
Author
|
@HiroQM could you please review this small PR that you requested, so that we can merge it soon? |
Collaborator
Author
|
Friendly ping about this old one @HiroQM :) |
HiroQM
approved these changes
Nov 14, 2025
Contributor
HiroQM
left a comment
HiroQM
left a comment
There was a problem hiding this comment.
I see, instead of taking the min/max, taking the mean of first/last 10 data and use those as amp. Also, amp can be positive or negative. More robust to noise.
LGTM👍
TheoLaudatQM
force-pushed
the
fix/exponential_decay_fit
branch
from
d06bbb5 to
1293384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the exponential fit to converge even if the exponential is inverted.