fix: Removing depreciated behavior to enable compatiblity with numpy==2#26
Open
sebastianorbell-qm wants to merge 1 commit intomainfrom
Open
fix: Removing depreciated behavior to enable compatiblity with numpy==2#26sebastianorbell-qm wants to merge 1 commit intomainfrom
sebastianorbell-qm wants to merge 1 commit intomainfrom
Conversation
|
|
TheoLaudatQM
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor patch to enable compatibility with numpy>2.0
All tests pass with numpy<2 and numpy>2
Tested downstream with qua-libs and this fixes the compatibility errors found there.
The One Breaking Change (now fixed)
feature_detection.py — _position_from_index and _width_from_index
Both functions were returning np.array([val]) (a 1-element array) but were called via xr.apply_ufunc(..., output_core_dims=[[]], vectorize=True), which expects a scalar
return. In numpy 2, this becomes a hard ValueError: setting an array element with a sequence rather than a DeprecationWarning.
Fix applied — return scalars directly instead of wrapping in np.array([...]).