Open
Conversation
yomach
requested changes
Nov 20, 2022
Collaborator
yomach
left a comment
yomach
left a comment
There was a problem hiding this comment.
Without looking at it too deeply, there are a few things that I can already say:
- Need to remove the "joe_testing" and "active_reset_full" folders
- Need to update main readme file
- Need to update changelog
- Need to add info about the control panel GUI (to readme)
- Need to remove configuration & IP addresses from the control panel GUI
- Need to run black formatting on everything
You can take a look at this for a bit more info:
https://github.com/qua-platform/py-qua-tools/blob/main/CONTRIBUTING.md#code-standards
i have not added a colormap to the plots whcih may be the next thing to do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.