Merged
Conversation
feat: performance improvements
fix: remove duplicate messages
fix: remove duplicate messages
fix: messages not being updated when last message is deleted
fix: bump used node version in ci
feat: rewrite caching system, use onScroll instead of onEndReached
Feat/new messages banner
feat: added passthrough for the maintainVisibleContentPosition
fix: lower close to top threshold
BREAKING CHANGE: react-native-firebase ^22.0.0 is now required
feat: updated react-native-firebase to v22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
What?
A method for scrolling to a message by its ID has been added.
How?
This is done by making sure the message is fetched and then finding the index of the message and then scroll to the index.
This also exposes
getItemLayoutto optimise the scrolling.Testing 🤞