Skip to content

Feat/new messages banner#23

Merged
melvin-qte merged 11 commits intomainfrom
feat/new-messages-banner
May 7, 2025
Merged

Feat/new messages banner#23
melvin-qte merged 11 commits intomainfrom
feat/new-messages-banner

Conversation

@melvin-qte
Copy link
Copy Markdown
Collaborator

@melvin-qte melvin-qte commented May 1, 2025

📖 Description

This PR fixes the following:

  • ❇️ A new optional property newMessagesBannerComponent that renders a banner in the middle section of the footer when new unread messages are detected.
  • 🐛 Fixes a bug where the scrollToBottomComponent is not shown

ℹ️ Good to know implementation details

Since the introduction of using the onScroll property instead of onEndReached has made the scrollToBottomComponent not working as expected, this PR instead implements the logic regarding the scrollToBottomComponent to CuteChat.

🎥 Demo

2025-05-06.10-43-20.mp4

🤞 Testing

  • I have tested the changes on iOS
  • I have tested the changes on Android

@melvin-qte melvin-qte marked this pull request as ready for review May 6, 2025 08:59
@melvin-qte melvin-qte requested a review from noahsvensson May 6, 2025 08:59
Copy link
Copy Markdown
Member

@noahsvensson noahsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@melvin-qte melvin-qte merged commit c3438f2 into main May 7, 2025
5 checks passed
@melvin-qte melvin-qte deleted the feat/new-messages-banner branch May 7, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants