esbuild: Move duplicated config into a shared file#526
Open
OrkunTokdemir wants to merge 1 commit into
Open
Conversation
OrkunTokdemir
force-pushed
the
orkun_dup_08_07_2026
branch
from
255302a to
41162bc
Compare
Put the shared esbuild logic in common/esbuild-config.mjs as a runEsbuild() helper. Each extension now only lists its own entry points and extra configs (qt-ui's webview) and passes in build and context, since the shared file can't find 'esbuild' on its own from the repo root. Also turn on --incremental tsc for all of them.
OrkunTokdemir
force-pushed
the
orkun_dup_08_07_2026
branch
from
41162bc to
eee7486
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the shared esbuild logic in common/esbuild-config.mjs as a
runEsbuild() helper. Each extension now only lists its own entry
points and extra configs (qt-ui's webview) and passes in build and
context, since the shared file can't find 'esbuild' on its own from
the repo root. Also turn on --incremental tsc for all of them.