Repository navigation
[4207][IMP] stock_owner_restriction: reflect oca changes - #177
Open
AungKoKoLin1997 wants to merge 3 commits into
Open
AungKoKoLin1997 wants to merge 3 commits into
AungKoKoLin1997 wants to merge 3 commits into
Conversation
Contributor
Author
|
The tests failed is related with stock_move_actual_date we fixed at qrtl/sfaj-oca#16. |
nobuQuartile
previously approved these changes
Mar 14, 2025
nobuQuartile
left a comment
nobuQuartile
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Code review and functional review
nobuQuartile
force-pushed
the
16.0-reflect-oca_stock_owner_restriction
branch
from
April 13, 2025 23:35
d9e53d0 to
d3c09b5
Compare
AungKoKoLin1997
changed the title
_compute_restrict_partner_id reads move_dest_ids.picking_id.owner_id and picking_id.partner_id via _get_owner_for_assign(), but these were not in @api.depends. As the field is stored, the value could go stale when the destination picking owner or the picking partner changes.
Contributor
Author
|
Pushed 99ddc8f, the latest commit of OCA/stock-logistics-workflow#1854 (3dda44e9, "complete restrict_partner_id dependencies"), so this branch now matches the current #1854. Refs https://github.com/qrtl/qrtl-dev-tools/issues/38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4207