Skip to content

refactor: remove dead suggestions module and deduplicate CLI helpers - #7

Merged
cursor[bot] merged 3 commits into
masterfrom
cursor/dead-code-cli-dedup-6196
Jun 29, 2026
Merged

refactor: remove dead suggestions module and deduplicate CLI helpers#7
cursor[bot] merged 3 commits into
masterfrom
cursor/dead-code-cli-dedup-6196

Conversation

@qkal

@qkal qkal commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

Continues maintainability cleanup by removing dead Phase 1 code and deduplicating CLI adapter helpers.

Findings addressed

  • suggestions.py and SuggestedAction were unused in production (Phase 2 uses NextAction in actions.py)
  • _tool_unavailable was duplicated across uv.py, ruff.py, and pyright.py
  • Safe path argument validation was duplicated between Ruff and Pyright adapters
  • path_to_display() was unused

Changes

  • Remove suggestions.py, SuggestedAction, and path_to_display()
  • Add cli/errors.py with tool_unavailable_diagnostic
  • Add cli/path_args.py with shared safe Python path argument helpers
  • Update UV/Ruff/Pyright adapters to use shared modules
  • Replace test_risk_suggestions.py with focused test_risk.py

Test plan

  • uv run ruff check .
  • uv run pyright --pythonpath .venv/bin/python
  • uv run pytest -q (328 passed)
Open in Web Open in Cursor 

- Delete unused suggestions.py and Phase 1 SuggestedAction model
- Extract shared tool_unavailable_diagnostic into cli/errors.py
- Extract shared safe path argument helpers into cli/path_args.py
- Consolidate risk tests into test_risk.py

Co-authored-by: Qkal <qkal@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 48b901f0-e3b4-4797-a6cb-4b645e8ec860

📥 Commits

Reviewing files that changed from the base of the PR and between 5b998f6 and 315081b.

📒 Files selected for processing (9)
  • src/agent_quality_mcp/cli/errors.py
  • src/agent_quality_mcp/cli/path_args.py
  • src/agent_quality_mcp/cli/pyright.py
  • src/agent_quality_mcp/cli/ruff.py
  • src/agent_quality_mcp/cli/uv.py
  • src/agent_quality_mcp/models.py
  • src/agent_quality_mcp/suggestions.py
  • tests/unit/test_risk.py
  • tests/unit/test_risk_suggestions.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/dead-code-cli-dedup-6196

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Qkal <qkal@users.noreply.github.com>
@cursor
cursor Bot marked this pull request as ready for review June 29, 2026 22:15

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Co-authored-by: Qkal <qkal@users.noreply.github.com>
@cursor
cursor Bot merged commit 694a540 into master Jun 29, 2026
3 checks passed
@cursor
cursor Bot deleted the cursor/dead-code-cli-dedup-6196 branch June 29, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants