Add unlockable hearts option#14
Open
Gandalf-The-IT-Wizard wants to merge 5 commits into
Open
Conversation
Author
|
Follow-up from testing: added Received Items advancements for unlockable heart rewards. The mod now generates nine tiered advancements under Received Items (Heart Unlock 1 through 9), each triggered by receiving the corresponding Heart tier. |
Author
|
Follow-up for testing feedback: split unlockable hearts into distinct Archipelago item names. What changed:
Verification:
New release asset SHA256:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
unlockable_heartsmode for Minecraft Archipelago:unlockable_heartsAPWorld toggle.Heartitems to the Minecraft item pool.Heartgrants one additional max heart, capped at vanilla ten hearts.HeartRewardhandling and AP item registry data.minecraft.apworldplus reviewable APWorld source underapworld_src/.Notes
The APWorld launcher normally follows upstream
versions/minecraft_versions.jsonfor the mod jar. For upstream release, that version metadata will need to point at a mod jar containing this feature; otherwise the APWorld can generate the option but the launcher may install an older mod that does not know how to apply it.Verification
./gradlew --no-daemon buildpassed with Java 21.gg/archipelago/aprandomizer/common/Utils/UnlockableHearts.classgg/archipelago/aprandomizer/items/HeartReward.classdata/aprandomizer/aprandomizer/archipelago_item/heart.jsonminecraft.apworldand compiled all packaged Python files.unlockable_heartsoutput key and a progressionHeartitem.Manual testing note
A fork release was tested and exposed that the APWorld launcher must download a matching mod jar. The fork release asset has been corrected; this PR branch keeps upstream URLs clean for maintainers.