Update all pixel specifications to 'density independent'#14
Open
dreamlibrarian wants to merge 1 commit into
Open
Update all pixel specifications to 'density independent'#14dreamlibrarian wants to merge 1 commit into
dreamlibrarian wants to merge 1 commit into
Conversation
On Mac at least the default true-pixel logic that kivy uses results in half-height text boxes and cramped layout. Adding dp() calls everywhere appears to make Mac look good (though I'd recommend checking windows for new weirdnesses.). ... dp(0) feels bizarre, but I kept it in case of yaml-like parsing shenanigans and to remind future updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running on mac, I get some interestingly trimmed textboxes.
After digging around looks like forcing 'density-independent pixels' for all the heights and padding looks good to me.
before:
after:
Not attached to this implementation, just hoping it might help!