Skip to content

Updated to Elixir 1.0.5, removed rebar stuff#5

Open
thecodeboss wants to merge 1 commit intoqhool:masterfrom
thecodeboss:elixir_1.0.5
Open

Updated to Elixir 1.0.5, removed rebar stuff#5
thecodeboss wants to merge 1 commit intoqhool:masterfrom
thecodeboss:elixir_1.0.5

Conversation

@thecodeboss
Copy link
Copy Markdown

I also included various style changes to reflect some Elixir standards. Newlines added to a few files.

Lastly, I changed the Travis script to simplify it slightly.

Feel free to suggest stuff, and let me know if my changes are a bit too drastic.

@qhool
Copy link
Copy Markdown
Owner

qhool commented Sep 10, 2015

I've merged the older PR 4 (I've been a bit negligent here, sorry :-) ) This disables compiling via rebar in travis, but I don't want to remove the rebar tooling. You'll need to rebase to resolve the conflicts.

Also, your single commit is a bit large; could you split up into a couple of commits -- one with the change to 1.0.5 and whatever code changes are needed for that, and another with the style changes?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure how hard it would be to get everything to compile under Elixir > 1.0, so I started a fresh Mix project (thus this file was auto-generated) and migrated each of the source files and whatnot manually. This file is exactly what is produced by Mix now, so I think we may as well keep it.

@scohen
Copy link
Copy Markdown

scohen commented Dec 8, 2015

@qhool With the exception of including .ez files in the .gitignore, this PR seems very reasonable; This project no longer compiles under Elixir > 1.0.

@thecodeboss
Copy link
Copy Markdown
Author

In terms of splitting this into multiple commits, I think it would be a lot of work to separate the 1.0.5 vs. style changes. A lot of code was auto-generated too.

I can look into redoing the rebar stuff when I've got time, but I'm not familiar with rebar, and don't currently have access to an Elixir environment (or even the original code I put up here, though it's easy enough to clone again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants