Update sample 1 to work with QGIS 3.x#4
Open
ThomasG77 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the sample to try out how to make my own QGIS C++ application for learning purpose. Not a C++/C dev, just getting started here.
If possible, a review could be nice in particular at
CMakeLists.txtas I made fixes to make things work but old Qt4 way code may remain. I've also changed the *.cmake files by borrowing code fromFindGEOS.cmakeand it depMacPlistMacros.cmakeand rename directorycmake_find_rulestocmakelike in official QGIS repo.The idea with the review would be about getting a good sample to then apply the same recipe to other samples instead of starting with bad code and config in each sample.