Support keyboard window movement in Overview - #41
Merged
Conversation
- Animate moved selections and preserve overview focus - Park windows safely while the overview is open
|
| Filename | Overview |
|---|---|
| Sources/DefiMacOS/OverviewController.swift | Adds keyboard movement, moved-window projection animation, selection alignment, and capture-unavailable panel behavior; no actionable defect was established. |
| Sources/DefiCore/Overview.swift | Adds projection interpolation, foreground overlay handling, and expanded workspace projection bounds for animation continuity. |
| Sources/DefiDaemon/DaemonOverview.swift | Integrates Overview parking and restoration with daemon layout application. |
| Sources/DefiDaemon/DaemonDesktop.swift | Parks active-workspace windows while fallback Overview mode is active. |
| Sources/DefiDaemon/DaemonDesktopSynchronization.swift | Avoids closing a parked Overview for native focus changes lacking a newer explicit focus intent. |
| Sources/DefiMacOS/HotKeyModels.swift | Maps configured movement and focus commands to appropriate Overview keyboard actions. |
| Sources/DefiMacOS/HotKeys.swift | Passes the configured command into Overview key-action classification. |
Sequence Diagram
sequenceDiagram
participant K as HotKey Tap
participant O as OverviewController
participant D as Daemon
participant R as DefiRuntime
participant P as Overview Projection
K->>O: moveUp / moveDown
O->>O: Compute stack or workspace drop target
O->>D: dropHandler(window, source, target)
D->>R: applyOverviewDrop
R-->>D: Updated runtime state
D->>O: Updated Overview snapshot
O->>P: Interpolate old and new projections
P-->>O: Animated moved-window presentation
Reviews (1): Last reviewed commit: "fix(overview): support keyboard window m..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing