Conversation
|
Well.. How this could be tested? Could you please open a pull request to a libp2p to test if that hunter version does not break libp2p builds? |
Author
Yes, currently working on it. There are linkage problems with spdlog. |
igor-egorov
reviewed
Feb 5, 2021
| SPDLOG_BUILD_TESTING=OFF | ||
| SPDLOG_BUILD_TESTS=OFF | ||
| SPDLOG_BUILD_BENCH=OFF | ||
| SPDLOG_FMT_EXTERNAL=NO |
There was a problem hiding this comment.
Please note that the initial value "NO" is also legal and was an equivalent for "OFF". docs ref
| hunter_default_version(flatbuffers VERSION 1.12.0) | ||
| hunter_default_version(flex VERSION 2.6.4) | ||
| hunter_default_version(fmt VERSION 6.1.2) | ||
| hunter_default_version(fmt VERSION 7.1.2) |
There was a problem hiding this comment.
FYI, this will break soralog with following error:
/build/source/src/impl/sink_to_console.cpp: In function 'void soralog::{anonymous}::put_reset_style(char*&)':
/build/source/src/impl/sink_to_console.cpp:57:32: error: 'fmt::internal' has not been declared
57 | const auto &style = fmt::internal::data::reset_color;
Member
There was a problem hiding this comment.
Branch master contains commits with fixed soralog.
Member
|
Let's close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mind that crc32c default version is lowered here, because the latest one intereferes with leveldb (will open an issue to the original hunter for that)