fix(view-data): Add image content type check for URLs in view data page#255
Open
kartik-gupta-ij wants to merge 2 commits intomasterfrom
Open
fix(view-data): Add image content type check for URLs in view data page#255kartik-gupta-ij wants to merge 2 commits intomasterfrom
kartik-gupta-ij wants to merge 2 commits intomasterfrom
Conversation
Anush008
approved these changes
Nov 1, 2024
Member
Anush008
left a comment
Anush008
left a comment
There was a problem hiding this comment.
Thanks @kartik-gupta-ij.
Super fast turnaround.
Anush008
reviewed
Nov 1, 2024
| useEffect(() => { | ||
| const fetchImageUrls = async () => { | ||
| const urls = []; | ||
| for (const key in data) { |
Member
There was a problem hiding this comment.
Just a thought.
Maybe a Promise.all to check them all at once?
…current checks in view data page
Member
|
Is that correct that with this change web-ui will send requests to all URLs on preview? |
Member
Yes. For the 10 points that are displayed, if the value is a URL and doesn't have an image extension in it, A HEAD request is made. |
Member
|
It is arguable, that this is actually desired behavior. What's the use-case? |
Member
Only one actually. To support image URLs like https://www.bothellwa.gov/ImageRepository/Document?documentID=8024. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes : #253