Open
Conversation
sfinkens
reviewed
Oct 18, 2024
Member
sfinkens
left a comment
sfinkens
left a comment
There was a problem hiding this comment.
Very nice! Just some minor questions
Comment on lines
+83
to
+84
| ict = ds["ICT"].mean(dim="back_scan").data[:, -3:] | ||
| space = ds["space_counts"].mean(dim="back_scan").data[:, -3:] |
Member
There was a problem hiding this comment.
Could
.data[:, -3:]
be replaced with
.sel(channel_name=slice(-3, None)).data
?
| prt_counts = xr.DataArray(hmf_array["telemetry"]["PRT"], | ||
| dims=["scan_line_index", "PRT_measurement"]) | ||
|
|
||
| # getting ICT counts |
Member
There was a problem hiding this comment.
I think you could also remove the comments
| return potential_tbm_header.copy() | ||
| data_set_name = cls._decode_data_set_name(data_set_name) | ||
| tbm_header = potential_tbm_header.copy() | ||
| tbm_header["data_set_name"] = data_set_name.decode().strip("\x80").encode() |
Member
There was a problem hiding this comment.
Could the .decode().strip().encode() part be moved to _decode_data_set_name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the telemetry fetching to use xarray, and in the case of POD, the hmf frames are also decoded in a clearer manner.