Add parsing for a few more Trade Republic event types#359
Open
shukali wants to merge 2 commits into
Open
Conversation
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parsing for a few more Trade Republic event types
While going through my transaction history I hit a bunch of events that pytr didn't recognize yet, so I added handling for them:
SSP_SECURITIES_TRANSFER_INCOMING) now get mapped to aTRANSFER_INevent, including ISIN parsing and a sensible default value.ADDRESS_CHANGED,TRADING_ORDER_REJECTED, the "Neues Gerät" (new device) title, and the "Kauforder abgelehnt" / "Dividende. Cash oder Stockdividende?" subtitles.Transaction,Overview,Fee,Shares), since some accounts seem to return these in English rather than German.Also added test fixtures + tests for the new cases (address changed, rejected buy order, new device, incoming securities transfer).
Closes #358