Migrate extension-cpp to stable API/ABI #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaylagawarecki
force-pushed
the
stable
branch
3 times, most recently
from
98ea688 to
75df317
Compare
4 tasks
|
|
||
| echo '::group::Install extension-cpp' | ||
| python setup.py develop | ||
| pip install -e . --no-build-isolation |
Author
There was a problem hiding this comment.
This change was needed to get CI to run properly.
Otherwise, CI was installing the nightly but using torch 2.7 to build the extension
| runner: linux.g5.4xlarge.nvidia.gpu | ||
| gpu-arch-type: cuda | ||
| gpu-arch-version: "12.4" | ||
| gpu-arch-version: "12.9" |
Author
There was a problem hiding this comment.
we no longer have cu nightlies for 12.4
Contributor
There was a problem hiding this comment.
lol CI for this repo is so outdated
mikaylagawarecki
force-pushed
the
stable
branch
3 times, most recently
from
07ef7e7 to
6f2afea
Compare
mikaylagawarecki
force-pushed
the
stable
branch
from
6f2afea to
ffab4c0
Compare
zou3519
reviewed
Dec 20, 2025
Comment on lines
+1
to
+4
| # C++/CUDA Extensions in PyTorch with LibTorch Stable ABI | ||
|
|
||
| An example of writing a C++/CUDA extension for PyTorch using the [LibTorch Stable ABI](https://pytorch.org/docs/main/notes/libtorch_stable_abi.html). | ||
| See [here](https://pytorch.org/tutorials/advanced/cpp_custom_ops.html) for the accompanying tutorial. |
Contributor
There was a problem hiding this comment.
are we pushing for everyone to use libtorch stable abi? Or do we expect people will want to use the regular api? How do people select between the two?
IMO if we're not ready for literally everyone to move to libtorch stable abi right now, we should provide multiple examples. One for libtorch stable, and one without.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanying tutorials change pytorch/tutorials#3701