Skip to content

Griffin-Lim phase init (issue 3828)#4191

Open
michiel-j wants to merge 2 commits intopytorch:mainfrom
michiel-j:griffinlim_phase_init
Open

Griffin-Lim phase init (issue 3828)#4191
michiel-j wants to merge 2 commits intopytorch:mainfrom
michiel-j:griffinlim_phase_init

Conversation

@michiel-j
Copy link
Copy Markdown

Proposed solution to issue 3828 "Ability to provide initial phase to Griffin-Lim" (link to issue 3828).
Change: if provided spectrogram is complex (and rand_init=False), then its phase is used as initialisation for Griffin-Lim phase estimation algorithm.
I also changed the docs of both src/torchaudio/transforms/_transforms.py and src/torchaudio/functional/functional.py.

Code used to test proposed solution (messy code): https://gist.github.com/michiel-j/740f704e50a4f812273fa9c5f88ae982

@michiel-j michiel-j requested a review from a team as a code owner May 6, 2026 08:18
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4191

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 6, 2026

Hi @michiel-j!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label May 6, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 6, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant