Skip to content

Remove pinning against torch version#4171

Merged
NicolasHug merged 1 commit intopytorch:mainfrom
NicolasHug:bbb
Jan 21, 2026
Merged

Remove pinning against torch version#4171
NicolasHug merged 1 commit intopytorch:mainfrom
NicolasHug:bbb

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

@NicolasHug NicolasHug requested a review from a team as a code owner January 21, 2026 14:09
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jan 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4171

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 12 Pending

As of commit 8c3f9c2 with merge base e123269 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed label Jan 21, 2026
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Lets target this for 2.10.1 release

@NicolasHug NicolasHug merged commit e284e58 into pytorch:main Jan 21, 2026
54 checks passed
@NicolasHug NicolasHug deleted the bbb branch January 21, 2026 14:36
@adamjstewart
Copy link
Copy Markdown

Isn't pytorch still required? We should keep torch without the version requirement.

@NicolasHug
Copy link
Copy Markdown
Member Author

it's required, but installing torchaudio on its own without also installing torch is always incorrect anyway (and unfortunately).

@adamjstewart
Copy link
Copy Markdown

Yes, but if you list torch as a dep (even without the version), pip will install torch when it install torchaudio. That is no longer true after this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants