Skip to content

Conversation

@SandSnip3r
Copy link
Contributor

@SandSnip3r SandSnip3r commented Feb 2, 2026

Description

Remove a check for trt-rtx which throws an exception if bf16 is used. trt-rtx does support bf16: https://docs.nvidia.com/deeplearning/tensorrt-rtx/latest/getting-started/support-matrix.html#hardware-and-precision

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla
Copy link

meta-cla bot commented Feb 2, 2026

Hi @SandSnip3r!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@SandSnip3r
Copy link
Contributor Author

Other places mention that trt-rtx does not support bf16:
tests/py/dynamo/llm/test_llm_models.py (lines 19-20)
tests/py/dynamo/models/test_dtype_support.py (line 205)
tests/py/dynamo/models/test_models_export.py (lines 411-412, 472-473)
tests/py/dynamo/models/test_dyn_models.py (lines 192-193)
tests/py/dynamo/models/test_models.py (lines 198-199, 240-241, 287-288, 430, 532, 581)
tests/py/dynamo/conversion/test_casts.py (line 72)
tests/py/dynamo/conversion/test_binary_ops_aten.py (line 242)

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant