Safe Error Handling #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added FetchError to be used by plugins to raise Custom Fetch Errors Added sys.exit for proper exit status!
amolkahat
requested changes
Nov 7, 2017
| return list_of_pull_requests | ||
|
|
||
| list_of_pulls = [] | ||
| r = requests.get(BASE_URL + "/%s/%s/pulls" % (username, repository)) |
Member
There was a problem hiding this comment.
Nice PR.
just do one thing instead of %s use '{}'.format(username).
| @@ -0,0 +1,25 @@ | |||
| import sys | |||
Member
There was a problem hiding this comment.
Instead of utils.py can you change the file name to something like review_board_Exceptions.py?
@bhavin192 what is your thougth on that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error handling decorator to be used by plugins for safe exit