-
Notifications
You must be signed in to change notification settings - Fork 3
Add tooltips and update uv.lock after installing pytest #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdded descriptive tooltip text to many UI widgets in Changes
Sequence Diagram(s)(omitted — changes are UI tooltip metadata only; no control-flow modifications to diagram) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/edit_python_pe/main.py (2)
119-127: Add tooltip for the list-view Quit button for parity.
Form view has a Quit tooltip; list view’s Quit lacks one.Apply this minimal diff:
self.quit_list_button = Button(BUTTON_QUIT, id="quit_list") +self.quit_list_button.tooltip = "Exit the app"
58-61: Consider centralizing tooltip strings for consistency/i18n.
Most strings are already centralized in.strings; tooltips could live there too to keep style consistent and ease localization.I can draft TOOLTIP_* constants in
.stringsand a patch that replaces these inline literals—want me to open a follow-up PR?Also applies to: 82-85, 119-119, 124-124, 140-140, 143-143, 146-146, 149-149, 152-152, 155-155, 158-158, 161-161, 166-166, 169-169, 172-172, 175-175, 178-178
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/edit_python_pe/main.py(4 hunks)
🔇 Additional comments (5)
src/edit_python_pe/main.py (5)
58-61: LGTM: SocialEntry tooltips add clarity.
Clear, action-oriented phrasing.
82-85: LGTM: AliasEntry tooltips add clarity.
Consistent verbs and tone with other tooltips.
140-161: LGTM: Form field tooltips improve usability.
Good coverage across inputs and text areas; phrasing is concise.
166-178: LGTM: Action button tooltips are clear and aligned with intent.
Nice consistency across Save, Back, Quit.
58-61:.tooltipproperty assignment is correct for Textual v3.1.0
Project pinstextual==3.1.0, and the official API uses the.tooltipproperty to set tooltips(github.com)Likely an incorrect or invalid review comment.
This PR adds helpful tooltips to the member form fields and buttons to improve user guidance and clarity:
who_area – "Describe who this member is (short bio)"
python_area – "Describe their experience with Python"
contributions_area – "List their contributions or achievements"
availability_area – "Mention when they are available (e.g., weekends)"
add_social_button – "Add a new social link"
add_alias_button – "Add a new alias"
save_button – "Save this member's profile"
back_button – "Go back to the members list without saving"
quit_button – "Exit the app"
Additionally, uv.lock has been updated after installing pytest to ensure dependencies are consistent.
This contribution addresses a good first issue by improving the usability and documentation of the member form.
Issue Reference:
Closes/Fixes #12
Summary by CodeRabbit