Conversation
Collaborator
Author
|
This takes care of the beautification stuff, now I can work on missing grammar |
Collaborator
Author
|
This is mostly fixed, the next things I will do are outside the scope of this PR. |
There was a problem hiding this comment.
Pull Request Overview
Refactors expression and binary operation handling by modularizing logic, simplifying function signatures, and expanding operand support; adjusts tests accordingly and changes default compile logging verbosity.
- Extracted expression evaluation into helper functions and simplified binary op handling to return computed values.
- Updated tests to use tracepoint section names and expanded a binary operation chain.
- Changed default logging level for compile() from WARNING to INFO.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/passing_tests/binops1.py | Modified test: changed section decorator, added print, and altered return value. |
| tests/passing_tests/binops.py | Modified test to use longer chained binary expression. |
| pythonbpf/functions_pass.py | Updated call to handle_binary_op to match new, reduced parameter list. |
| pythonbpf/expr_pass.py | Refactored eval_expr into smaller helpers for names, constants, attributes, and deref calls. |
| pythonbpf/codegen.py | Changed default log level of compile() to INFO (behavioral/API change). |
| pythonbpf/binary_ops.py | Refactored binary op handling: added operand resolver, recursive support, and operation mapping. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.