Remove dead logic - #29
Merged
Merged
Conversation
ammaraskar
approved these changes
Apr 9, 2026
ammaraskar
left a comment
ammaraskar
left a comment
Member
There was a problem hiding this comment.
heh this call must have been required in the C API at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_SetProgramNameis removed in 3.15. I also have no idea as to why it failed before that, and unfortunately the commit message of 1c8b082 (which put it in the#if 0block) is quite brief.Furthermore, seeing as we haven't had any issues I don't see a reason to set the program name, so I suggest we just remove it.