Skip to content

Minor improvements to the Emscripten instructions#1795

Open
hoodmane wants to merge 6 commits intopython:mainfrom
hoodmane:emscripten-instructions
Open

Minor improvements to the Emscripten instructions#1795
hoodmane wants to merge 6 commits intopython:mainfrom
hoodmane:emscripten-instructions

Conversation

@hoodmane
Copy link
Copy Markdown
Contributor

No description provided.

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented Apr 22, 2026

Documentation build overview

📚 CPython devguide | 🛠️ Build #32379820 | 📁 Comparing a8df476 against latest (6c41828)

  🔍 Preview build  

2 files changed
± versions/index.html
± getting-started/setup-building/index.html

Comment on lines -555 to -556
by setting the ``EM_COMPILER_WRAPPER`` environment, but this step will only
take effect if it is done **after** ``emsdk_env.sh`` is sourced (otherwise, the
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be difficult to do now since our script automatically sources emsdk_env.sh. Thankfully it is not true that it has to be set after sourcing emsdk_env.sh. Ccache must be at least version 4.3

Comment thread getting-started/setup-building.rst Outdated
subsequent runs unless there is a change in the version or build script for the
dependency.

It is assumed that nvm_ is installed in `${HOME}/.nvm`.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should search for nvm first in NVM_DIR then in XDG_CONFIG_HOME and then in HOME since that's where nvm likes to install itself. But we don't currently do that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we should add a HOST_RUNNER environment variable so people can set export HOST_RUNNER=node if they don't want nvm to be used. Currently you can do that by passing --host-runner=node so I guess I can document that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant