Skip to content

gh-142119: Clarify that one contextvars.Token can only reset once in a lifetime #143693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 5 commits into from
Jan 27, 2026
Merged

gh-142119: Clarify that one contextvars.Token can only reset once in a lifetime #143693

encukou merged 5 commits into from
Jan 27, 2026
+3 −1

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Jan 11, 2026 •
edited by github-actions bot
Loading

@johnslavik johnslavik added docs Documentation in the Doc dir skip news labels Jan 11, 2026
@johnslavik johnslavik requested a review from 1st1 as a code owner January 11, 2026 15:11
@johnslavik johnslavik added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 11, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jan 11, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 11, 2026
Closed
StanFromIreland
StanFromIreland reviewed Jan 11, 2026
View reviewed changes
@johnslavik @StanFromIreland
Preserve spacing between sections
c29b7ec 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
johnslavik
johnslavik commented Jan 17, 2026
View reviewed changes
@StanFromIreland
Copy link
Member

StanFromIreland commented Jan 26, 2026

Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide.

@johnslavik
Copy link
Member Author

johnslavik commented Jan 26, 2026 •
edited
Loading

Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide.

I've just fixed a conflict, so this was necessary.
It conflicted with the other PR that's been just merged (see the issue).

A conflict that would make it harder for @encukou to potentially merge this :)

@StanFromIreland
Copy link
Member

StanFromIreland commented Jan 26, 2026

Oh sorry I didn't notice

@encukou encukou merged commit 487bd2d into python:main Jan 27, 2026
29 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 27, 2026

Thanks @johnslavik for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jan 27, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2026
@johnslavik @miss-islington
pythongh-142119: Clarify that one contextvars.Token can only reset …
b1b15cd 
…once in a lifetime (pythonGH-143693)

(cherry picked from commit 487bd2dea538e36cb620dd9e0f298d731b9ede8a)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2026
@johnslavik @miss-islington
pythongh-142119: Clarify that one contextvars.Token can only reset …
e97da96 
…once in a lifetime (pythonGH-143693)

(cherry picked from commit 487bd2d)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2026

GH-144266 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 27, 2026
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2026

GH-144267 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 27, 2026
encukou pushed a commit that referenced this pull request Jan 27, 2026
@miss-islington @johnslavik
[3.14] gh-142119: Clarify that one contextvars.Token can only reset…
b82b12b 
… once in a lifetime (GH-143693) (GH-144266)

(cherry picked from commit 487bd2d)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
encukou pushed a commit that referenced this pull request Jan 27, 2026
@miss-islington @johnslavik
[3.13] gh-142119: Clarify that one contextvars.Token can only reset…
d6f4fb8 
… once in a lifetime (GH-143693) (GH-144267)

(cherry picked from commit 487bd2d)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnslavik @StanFromIreland @encukou