Repository navigation
Do not read past the end of a tuple subclass with a larger __len__ - #10359
Open
Parsiffall1 wants to merge 2 commits into
Open
Parsiffall1 wants to merge 2 commits into
Parsiffall1 wants to merge 2 commits into
Conversation
Member
|
Note that I'm not sure if the issue needs to be fixed. |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10358.
Changes proposed in this pull request:
PyPath_Flatten()uses the length fromPyObject_Length(), which calls a subclass's__len__. For tuples it then read items with the uncheckedPyTuple_GET_ITEM(), so a tuple subclass that reported a larger length read past the end of the tuple and crashed. This usesPyTuple_GetItem()instead, which raisesIndexError, matching what already happens for list subclasses.__len__is larger than its contents.