Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ImageFile.load(), for a zero dimension image, we can skip loading the tile.While this simplification is straightforward on face value, the fact that it only occurs after seeking raises the question of "Should we accept zero dimension frames, since we don't accept zero dimension images? We currently do, but should we keep doing that?"
#10080 thinks no, I believe feeling that this is inconsistent.
I think rejecting zero size images is because we want meaningful data in a file, but if meaningful data does exist in the first frame, then I'm willing to let other frames be empty.