Repository navigation
Return zero from ImagePath compact() if there are no points to remove - #10126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an
ImagePathwith zero points, and then callingcompact()should return the number of points that were removed in the compacting process.Instead this gives -1, as it is presumed that is at least 1 point in the path.
Pillow/src/path.c
Line 336 in e62e2e9
Pillow/src/path.c
Line 345 in e62e2e9
Pillow/src/path.c
Line 355 in e62e2e9
Instead, let's return early, saying that zero points were removed.