Repository navigation
Remove unused cleanup return value - #10101
Merged
Merged
Conversation
akx
approved these changes
Oct 2, 2026
akx
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a small note about zlib, but it's fine (it's been unchecked forever anyway).
|
|
||
| /* Clean up */ | ||
| if (context->previous) { | ||
| inflateEnd(&context->z_stream); |
Contributor
There was a problem hiding this comment.
Looking at the docs, inflateEnd is fallible, but the conditions in which it would fail seem rare enough that it's not worth it to check here:
On error,
inflateEnd()shall returnZ_STREAM_ERROR. The following conditions shall be treated as an error:
- The state in
streamis inconsistent.streamis NULL.- The
zfreefunction pointer is NULL.
So this is fine 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return values from C's
cleanup()methodsPillow/src/decode.c
Lines 143 to 150 in d01e2fe
Pillow/src/encode.c
Lines 110 to 117 in d01e2fe
aren't used in Python.
Pillow/src/PIL/ImageFile.py
Line 423 in d01e2fe
Pillow/src/PIL/ImageFile.py
Line 702 in d01e2fe