Use distro automake's config.guess#141
Open
vemek wants to merge 1 commit into
Open
Conversation
Closes pyroscope#137 The config.guess that ships with the version of xmlrpc-c we use is quite outdated - it's from 2009. It can't identify some modern systems, specifically ARM64 (i.e aarch64. x86_64 is obviously okay, I expect armv7l also as there is some mention of RPi 3's in the script). To work around this without using a different version of xmlrpc-c, we can simply copy in the newer config.guess that ships with the version of automake we install from the distro. This results in a successful build on newer platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137
The config.guess that ships with the version of xmlrpc-c RTPS uses is quite
outdated - it's from 2009. It can't identify some modern systems,
specifically ARM64 (i.e aarch64). x86_64 is obviously okay, I expect armv7l
also as there is some mention of RPi 3's in the script.
To work around this without using a different version of xmlrpc-c, we can
simply copy in the newer config.guess that ships with the version of
automake we install from the distro. This is automake's recommended
solution. This results in a successful build on newer platforms.
Previous results:
I've tested that this change builds packages successfully for:
I have not been able to test for Arch on ARM64 as they do not supply a docker image.