Skip to content

feat: drop Python 3.8#1157

Draft
henryiii wants to merge 2 commits intopypa:mainfrom
henryiii:henryiii/feat/drop38
Draft

feat: drop Python 3.8#1157
henryiii wants to merge 2 commits intopypa:mainfrom
henryiii:henryiii/feat/drop38

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

Dropping Python 3.8. Holding in draft for a bit to make sure there are no regressions in 26.1.

🤖 Assisted-by: OpenCode:Kimi-K2.5

Assisted-by: OpenCode:Kimi-K2.5
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Assisted-by: OpenCode:Kimi-K2.5
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Comment thread tests/test_errors.py
Comment on lines +65 to +66
pytest.raises(packaging.errors.ExceptionGroup) as exc_info,
collector.on_exit("exiting"),
Copy link
Copy Markdown
Contributor Author

@henryiii henryiii Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Ruff does this automatically, but it does require the new parser, which is technically optional till 3.10, there's a flag to go back. So maybe we should support both? Does anyone care about the old parser in 3.9?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, this is only in tests, I don't care about supported this flag in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants