Draft
Conversation
Assisted-by: OpenCode:Kimi-K2.5 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Assisted-by: OpenCode:Kimi-K2.5 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
notatallshaw
approved these changes
Apr 15, 2026
henryiii
commented
Apr 15, 2026
Comment on lines
+65
to
+66
| pytest.raises(packaging.errors.ExceptionGroup) as exc_info, | ||
| collector.on_exit("exiting"), |
Contributor
Author
There was a problem hiding this comment.
BTW, Ruff does this automatically, but it does require the new parser, which is technically optional till 3.10, there's a flag to go back. So maybe we should support both? Does anyone care about the old parser in 3.9?
Contributor
Author
There was a problem hiding this comment.
Ahh, this is only in tests, I don't care about supported this flag in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping Python 3.8. Holding in draft for a bit to make sure there are no regressions in 26.1.
🤖 Assisted-by: OpenCode:Kimi-K2.5