Skip to content

Allow spaces in license files patterns #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takluyver merged 1 commit into from
Apr 25, 2026
+3 −1
Merged

Allow spaces in license files patterns #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flit_core/flit_core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class ConfigError(ValueError):


default_license_files_globs = ['COPYING*', 'LICEN[CS]E*', 'NOTICE*', 'AUTHORS*']
license_files_allowed_chars = re.compile(r'^[\w\-\.\/\*\?\[\]]+$')
license_files_allowed_chars = re.compile(r'^[\w\-\.\/\*\?\[\] ]+$')


def read_flit_config(path):
Expand Down
Empty file added flit_core/tests_core/samples/pep621_license_files/Third-Party Notices.md
View file
Open in desktop
Empty file.
2 changes: 2 additions & 0 deletions flit_core/tests_core/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,8 @@ def test_license_expr_error_unsupported_with(invalid_expr: str):
({'license-files': ["**/LICENSE*"]}, ["LICENSE", "module/vendor/LICENSE_VENDOR"]),
({'license-files': ["module/vendor/LICENSE*"]}, ["module/vendor/LICENSE_VENDOR"]),
({'license-files': ["LICENSE", "module/**/LICENSE*"]}, ["LICENSE", "module/vendor/LICENSE_VENDOR"]),
# It was decided the banning spaces was an oversight
({'license-files': ["Third-Party Notices.md"]}, ["Third-Party Notices.md"]),
# Add project.license.file + match default patterns
({'license': {'file': 'module/vendor/LICENSE_VENDOR'}}, ["LICENSE", "module/vendor/LICENSE_VENDOR"]),
])
Expand Down