Skip to content

Improve string formatting for error messages about license-files glob patterns #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takluyver merged 1 commit into from
Mar 10, 2026
+5 −5
Merged

Improve string formatting for error messages about license-files glob patterns #794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions flit_core/flit_core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,17 +289,17 @@ def _license_files_from_globs(project_dir: Path, globs, warn_no_files = True):
for pattern in globs:
if isabs_ish(pattern):
raise ConfigError(
f"Invalid glob pattern for [project.license-files]: '{pattern}'. "
f"Invalid glob pattern for [project.license-files]: {pattern!r}. "
"Pattern must not start with '/'."
)
if ".." in pattern:
raise ConfigError(
f"Invalid glob pattern for [project.license-files]: '{pattern}'. "
f"Invalid glob pattern for [project.license-files]: {pattern!r}. "
"Pattern must not contain '..'"
)
if license_files_allowed_chars.match(pattern) is None:
raise ConfigError(
"Invalid glob pattern for [project.license-files]: '{}'. "
f"Invalid glob pattern for [project.license-files]: {pattern!r}. "
"Pattern contains invalid characters. "
"https://packaging.python.org/en/latest/specifications/pyproject-toml/#license-files"
)
Expand All @@ -311,12 +311,12 @@ def _license_files_from_globs(project_dir: Path, globs, warn_no_files = True):
]
except ValueError as ex:
raise ConfigError(
f"Invalid glob pattern for [project.license-files]: '{pattern}'. {ex.args[0]}"
f"Invalid glob pattern for [project.license-files]: {pattern!r}. {ex.args[0]}"
)

if not files and warn_no_files:
raise ConfigError(
f"No files found for [project.license-files]: '{pattern}' pattern"
f"No files found for [project.license-files]: {pattern!r} pattern"
)
license_files.update(files)
return license_files
Expand Down