Skip to content

fix: state device widget init signal block #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlambert03 merged 2 commits into from
May 15, 2026
Merged

fix: state device widget init signal block #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62fdcb2
fix: don't write back to core when initializing StateDeviceWidget
hinderling May 13, 2026
0b75db1
fix: don't write back to core when initializing StageWidget
hinderling May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pymmcore_widgets/_deprecated/_device_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ def __init__(
self._combo.currentIndexChanged.connect(self._on_combo_changed)
self._changing = False
self._refresh_choices()
self._combo.setCurrentText(self._mmc.getStateLabel(self._device_label))
with signals_blocked(self._combo):
self._combo.setCurrentText(self._mmc.getStateLabel(self._device_label))

self.setLayout(QHBoxLayout())
self.layout().setContentsMargins(0, 0, 0, 0)
Expand Down
13 changes: 7 additions & 6 deletions src/pymmcore_widgets/control/_stage_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,12 +375,13 @@ def _on_system_cfg(self) -> None:
self._set_as_default()

def _set_as_default(self) -> None:
if self._dtype is DeviceType.XYStage:
if self._mmc.getXYStageDevice() == self._device:
self._set_as_default_btn.setChecked(True)
elif self._dtype is DeviceType.Stage:
if self._mmc.getFocusDevice() == self._device:
self._set_as_default_btn.setChecked(True)
with signals_blocked(self._set_as_default_btn):
if self._dtype is DeviceType.XYStage:
if self._mmc.getXYStageDevice() == self._device:
self._set_as_default_btn.setChecked(True)
elif self._dtype is DeviceType.Stage:
if self._mmc.getFocusDevice() == self._device:
self._set_as_default_btn.setChecked(True)

@Slot(bool)
def _on_radiobutton_toggled(self, state: bool) -> None:
Expand Down
Loading