Skip to content

fix: "p" at the front of axis order when auto-inserting current stage position #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlambert03 merged 2 commits into from
Apr 8, 2026
Merged

fix: "p" at the front of axis order when auto-inserting current stage position #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
affa5b9
fix: always insert "p" at the front of the axis order when no positio…
boydcpeters Apr 8, 2026
bcbdad5
test: update test to check whether "p" is the first if no position is…
boydcpeters Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/pymmcore_widgets/mda/_core_mda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,8 @@ def value(self) -> MDASequence:
# not be in the event
if "p" not in val.axis_order:
axis_order = list(val.axis_order)
# add the "p" axis at the beginning or after the "t" as the default
if "t" in axis_order:
axis_order.insert(axis_order.index("t") + 1, "p")
else:
axis_order.insert(0, "p")
# Always insert "p" at the front
axis_order.insert(0, "p")
replace["axis_order"] = tuple(axis_order)

if replace:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_useq_core_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ def test_mda_no_pos_set(global_mmcore: CMMCorePlus, qtbot: QtBot):
assert round(wdg.value().stage_positions[0].y) == 20
assert round(wdg.value().stage_positions[0].z) == 30

assert "p" in wdg.value().axis_order
assert wdg.value().axis_order[0] == "p"


@pytest.mark.parametrize("ext", ["json", "yaml"])
Expand Down
Loading