Skip to content

Small improvement to error messages in asyncadapter #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almarklein merged 1 commit into from
May 18, 2026
Merged

Small improvement to error messages in asyncadapter #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rendercanvas/utils/asyncadapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,9 @@ def step(self):
return self._close()

error = None

if not (isinstance(result, dict) and result.get("wait_method", None)):
error = f"Incompatible awaitable result {result!r}. Maybe you used asyncio or trio (this does not run on either)?"
error = f"Incompatible awaitable result {result!r} from coro {self.coro!r}. Maybe you used asyncio or trio (this does not run on either)?"
else:
wait_method = result["wait_method"]
if wait_method == "sleep":
Expand All @@ -152,8 +153,6 @@ def step(self):
error = f"Unknown wait_method {wait_method!r}."

if error:
logger.error(
f"Incompatible awaitable result {result!r}. Maybe you used asyncio or trio (this does not run on either)?"
)
logger.error(error)
self.cancel()
self.call_step_later(0)
Loading