Split MultiVector.__init__ into three factory methods#292
Draft
eric-wieser wants to merge 2 commits intopygae:masterfrom
Draft
Split MultiVector.__init__ into three factory methods#292eric-wieser wants to merge 2 commits intopygae:masterfrom
MultiVector.__init__ into three factory methods#292eric-wieser wants to merge 2 commits intopygae:masterfrom
Conversation
|
This pull request introduces 1 alert when merging ecde7d5 into 4e470ab - view on LGTM.com new alerts:
|
eric-wieser
force-pushed
the
multivector-ctor-tweaks
branch
from
ecde7d5 to
aca0818
Compare
This makes the API a little bit easier to explain, and removes the opportunity for passing orthogonal options at the same time.
eric-wieser
force-pushed
the
multivector-ctor-tweaks
branch
from
aca0818 to
5cc3803
Compare
eric-wieser
changed the title
MultiVector.__init__ into three static methodsMultiVector.__init__ into three factory methods
Member
Author
|
Upstream issue in sphinx breaks the docs here: patch in sphinx-doc/sphinx#7384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the API a little bit easier to explain, and removes the opportunity for passing orthogonal options at the same time.
Let's see whether the resulting docs look ok