Fix PR #17 review items: PyCall env, codecov, compat bounds#22
Fix PR #17 review items: PyCall env, codecov, compat bounds#22
Conversation
1. Point PyCall at system Python so it uses the pip-installed galgebra rather than falling back to its own Conda environment 2. Explicitly pass coverage-lcov.info to codecov-action v4 3. Set julia compat to "1.10, 1.11" to match the CI matrix
The separate Pkg.build("PyCall") step failed because the manifest
wasn't instantiated yet. Instead, set PYTHON env var on the Test step
so PyCall picks up the system Python during Pkg.build("GAlgebra").
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
=======================================
Coverage 80.43% 80.43%
=======================================
Files 4 4
Lines 92 92
=======================================
Hits 74 74
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Review — 3 issues + design consistency concern1.
|
- deps/build.jl: detect existing galgebra, check version range [0.6.0, 0.7.0), install controlled version only when needed - src/GAlgebra.jl: replace pyimport_conda with pyimport, add GALGEBRA_DEBUG env var for diagnostics - ci.yml: explicit pip install galgebra==0.6.0, PYTHON env var for PyCall, bump Actions (checkout v4, setup-python v5, setup-julia v2, codecov v4) - README: add Python dependency and diagnostics documentation Supersedes #22. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Follow-up to #17 per review comments.
PyCall Python env (HIGH): Added
Configure PyCall to use system Pythonstep so PyCall picks up the pip-installedgalgebra==0.6.0rather than falling back to its own Conda env with an unpinned version.codecov file (MEDIUM): Explicitly pass
files: coverage-lcov.infotocodecov-action@v4instead of relying on auto-detection.compat bounds (MEDIUM):
julia = "1.10"->julia = "1.10, 1.11"to match the CI matrix explicitly.