Open
Conversation
New wrappers in mv.jl: - undual() — inverse of dual(); @test undual(dual(v)) == v - mag2() — grade-wise sum of |norm2|; differs from norm()^2 in non-Euclidean metrics - mag() — sqrt(mag2()); equals norm() only for Euclidean metrics - shirokov_inverse() — inverse via arXiv:2005.04015 Theorem 4 - hitzer_inverse() — efficient inverse for n<6 (Hitzer–Sangwine 2017) - sp(A, B) — (A*B).scalar(), distinct from A⊛B = (A*~B).scalar() Also tests that g_invol() and ccon() (new names in 0.6.0) agree with the existing involute() and conj() wrappers. Closes #13
lodyai
bot
force-pushed
the
feat/13-wrap-new-mv-methods
branch
from
fead936 to
76d1b26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 80.43% 80.64% +0.21%
==========================================
Files 4 4
Lines 92 93 +1
==========================================
+ Hits 74 75 +1
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Adds Julia wrappers for the new
Mvmethods introduced in galgebra 0.6.0:undual(A)A.undual()dual()mag2(A)A.mag2()Σ|norm2(⟨A⟩ᵣ)|; differs fromnorm()^2for non-Euclidean metricsmag(A)A.mag()sqrt(mag2(A)); equalsnorm()only for Euclideanshirokov_inverse(A)A.shirokov_inverse()hitzer_inverse(A)A.hitzer_inverse()sp(A, B)A.sp(B)(A*B).scalar(), distinct fromA ⊛ B = (A*~B).scalar()Also verifies that the new
g_invol()andccon()Python-side names agree with the existinginvolute()andconj()wrappers (they're aliases, no new Julia names needed).Each new function has a delegation smoke test plus a property test where applicable.