Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 80.43% 80.43%
=======================================
Files 4 4
Lines 92 92
=======================================
Hits 74 74
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lodyai
bot
force-pushed
the
fix/16-missing-test-and-paper-gaps
branch
from
d639034 to
0c976ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Lines 154, 215, 284 in
test/runtests.jlhad bare equality expressions that were never evaluated as tests. Adding@testto each:A[r] == A.grade(r) == A.get_grade(r)(grade API consistency)Ar ⨼ Br == Ar ⨽ Br == (Ar * Br).scalar()(equal-grade inner products)Ar ∧ (Bs ∧ Ct) == (Ar * Bs * Ct)[r + s + t](associativity of wedge w/ grade selection)Also updated the summary comment to reference #14 and #15 for the remaining broken identities.