fix(dependency): [#318] remove torchvision from core dependencies - #319
Closed
ssarmin wants to merge 1 commit into
Closed
fix(dependency): [#318] remove torchvision from core dependencies#319ssarmin wants to merge 1 commit into
ssarmin wants to merge 1 commit into
Conversation
torchvision>=0.25.0 was a hard dependency, requiring torch 2.10-2.12 which has no prebuilt wheels for Intel Mac (x86_64) and broke installs for users who don't touch torch-based trainers. It's already declared in the vision/torch dependency-groups, so no functionality is lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #318
torchvision>=0.25.0was listed as a hard dependency inpyproject.toml, requiring torch 2.10–2.12, which has no prebuilt wheels for Intel Mac (x86_64).torchvision/torchare already declared in thevisionandtorchdependency-groups, so removing it from coredependenciesdoesn't remove any functionality.Changes
torchvision>=0.25.0from[project.dependencies]inpyproject.tomluv.lockTest plan
uv run ruff check fenn/— passeduv run ty check fenn/— passeduv run pytest tests/unit --cov --cov-branch— passedfennstill imports cleanly (import fenn; fenn.Fenn)uv sync --group dev) thattorch/torchvisionstill install correctly via the
visiongroup