Dev release pyet 1.5.0 - #94
Conversation
Added an Actual vapor pressure estimation when RH is not provided
removed tmean from extraterrestrial_r in function jensen_haise
There was a problem hiding this comment.
Pull request overview
Prepares the pyet 1.5.0 development release by bumping the package version, updating packaging/dependency metadata, and adjusting a few implementation/docs details to align with the upcoming release.
Changes:
- Bump package version to
1.5.0and update project URLs/dependency constraints inpyproject.toml. - Fix/adjust PET-related computations and meteorological utilities (e.g.,
extraterrestrial_rcall signature;calc_eafallback behavior). - Update Sphinx documentation configuration and minor test/template tweaks.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/testfao56.py |
Adjusts daylight-hours test to extract a scalar from the returned sequence. |
pyproject.toml |
Updates core dependency minimums/constraints, RTD extra deps, and project URLs. |
pyet/version.py |
Bumps __version__ to 1.5.0. |
pyet/radiation.py |
Fixes extraterrestrial_r call for Jensen–Haise method 1; small docstring/logic tidy-ups. |
pyet/meteo_utils.py |
Refactors module docstring and adds a dewpoint-based fallback path to calc_ea. |
docs/conf.py |
Updates Sphinx config for newer Sphinx/pydata-sphinx-theme conventions and notebook execution timeout. |
.github/pull_request_template.md |
Tweaks headings and adds a reminder about targeting dev-branch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mvremec
left a comment
There was a problem hiding this comment.
Reviewed all 7 changed files. Math checks out:
- jensen_haise(method=1) signature fix is correct, the call now matches extraterrestrial_r(tindex, lat)
- hargreaves refactor preserves both method 0 and 1; scoping chs to method 1 is good
- calc_ea Tdew ≈ Tmin fallback follows FAO-56 Eq. 48
- Dep bumps, pandas <3.0 cap, and the phydrus/pyet → pyet-org/pyet URL fixes all fine
Approving for 1.5.0.
Please re-review, no AI ;-) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@mvremec a quick review please ;-) |
mvremec
left a comment
There was a problem hiding this comment.
Thanks for the additions! Runs without problems. Will look into implementing the Turc correction and hourly calculations in the next PR or fork.
Short Description
Release PyET 1.5.0. Minor changes and updates.