Skip to content

Dev release pyet 1.5.0 - #94

Merged
raoulcollenteur merged 15 commits into
masterfrom
dev
May 26, 2026
Merged

raoulcollenteur merged 15 commits into
masterfrom
dev

Conversation

@raoulcollenteur

@raoulcollenteur raoulcollenteur commented May 1, 2026 •

Copy link
Copy Markdown
Member

Short Description

Release PyET 1.5.0. Minor changes and updates.

@raoulcollenteur raoulcollenteur self-assigned this May 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the pyet 1.5.0 development release by bumping the package version, updating packaging/dependency metadata, and adjusting a few implementation/docs details to align with the upcoming release.

Changes:

  • Bump package version to 1.5.0 and update project URLs/dependency constraints in pyproject.toml.
  • Fix/adjust PET-related computations and meteorological utilities (e.g., extraterrestrial_r call signature; calc_ea fallback behavior).
  • Update Sphinx documentation configuration and minor test/template tweaks.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/testfao56.py Adjusts daylight-hours test to extract a scalar from the returned sequence.
pyproject.toml Updates core dependency minimums/constraints, RTD extra deps, and project URLs.
pyet/version.py Bumps __version__ to 1.5.0.
pyet/radiation.py Fixes extraterrestrial_r call for Jensen–Haise method 1; small docstring/logic tidy-ups.
pyet/meteo_utils.py Refactors module docstring and adds a dewpoint-based fallback path to calc_ea.
docs/conf.py Updates Sphinx config for newer Sphinx/pydata-sphinx-theme conventions and notebook execution timeout.
.github/pull_request_template.md Tweaks headings and adds a reminder about targeting dev-branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyet/meteo_utils.py Outdated
Comment thread pyet/meteo_utils.py Outdated
mvremec
mvremec previously approved these changes May 4, 2026

@mvremec mvremec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 7 changed files. Math checks out:

  • jensen_haise(method=1) signature fix is correct, the call now matches extraterrestrial_r(tindex, lat)
  • hargreaves refactor preserves both method 0 and 1; scoping chs to method 1 is good
  • calc_ea Tdew ≈ Tmin fallback follows FAO-56 Eq. 48
  • Dep bumps, pandas <3.0 cap, and the phydrus/pyet → pyet-org/pyet URL fixes all fine

Approving for 1.5.0.

@raoulcollenteur

Copy link
Copy Markdown
Member Author

Reviewed all 7 changed files. Math checks out:

  • jensen_haise(method=1) signature fix is correct, the call now matches extraterrestrial_r(tindex, lat)
  • hargreaves refactor preserves both method 0 and 1; scoping chs to method 1 is good
  • calc_ea Tdew ≈ Tmin fallback follows FAO-56 Eq. 48
  • Dep bumps, pandas <3.0 cap, and the phydrus/pyet → pyet-org/pyet URL fixes all fine

Approving for 1.5.0.

Please re-review, no AI ;-)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@raoulcollenteur

Copy link
Copy Markdown
Member Author

@mvremec a quick review please ;-)

@mvremec mvremec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions! Runs without problems. Will look into implementing the Turc correction and hourly calculations in the next PR or fork.

@raoulcollenteur
raoulcollenteur merged commit a97c97c into master May 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants