Let requires-python set the ruff target version - #76
Open
Danipulok wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Delete
target-version = "py39"from[tool.ruff], and rewrite the twoisinstancecalls that the raised target flags.Why
requires-pythonis>=3.10, so ruff was linting the package against a floor two releases below the one it declares.Deleting the key rather than updating it means it cannot drift again: when
target-versionis absent, ruff reads the floor fromrequires-python.The higher target surfaces two
UP038findings inrun_code.py. Both are rewritten to theX | Yform, whichisinstancehas accepted since 3.10.How to test
make lint,make typecheckand the test suite. No behaviour change.