Fix the ruff include glob so example/ is actually linted - #75
Open
Danipulok wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Point the ruff
includeglob atexample/, and addexample/test_example.pytoexclude.Why
The glob names
examples/, but the directory isexample/, so it has never matched anything and the example package the suite runs against is not linted at all.That file is the one thing under
example/that cannot be linted or formatted, because it is its own test data:find_examplesparses its docstrings.docstring-code-formatrewrites the#>print markers inside them to# >, andD212would collapse the two docstring styles thattest_python_self_change_docstyleexists to cover. It joinstests/cases_update/*.pyinexclude, which already holds test data for the same reason.How to test
make lintpasses and leavesexample/test_example.pyuntouched. Add any other.pyfile underexample/andruff checknow reports it.