Add missing type annotations - #74
Open
Danipulok wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pyrightno longer infers them asUnknown.not_printinrun_code.py, which nothing calls.reportUnknown*rules so the gap cannot come back.pythonVersion = "3.10"to matchrequires-python.Why
Most of the package was annotated already, but a handful of parameters and returns were not, and nothing in the toolchain reported them.
typeCheckingMode = "strict"would be the blunt way to enforce it, but it is down to 6 diagnostics on this branch and none of them is a missing annotation: three are fixturespyrightcannot see being called or used across modules, two arerequest.node, whichpytestleaves untyped deliberately, and one is the deprecatedco_lnotabgetter. The four rules cover exactly what this change is about and nothing else.The
pythonVersionpin matters on its own: without itpyrightchecks against whatever interpreter the job installed, 3.12 in CI today, so a 3.11-only annotation passesmake typecheckand only surfaces in the 3.10 test job, if at all.How to test
make lint,make typecheck, andmake test-all-pythonfor 3.10 through 3.14. No behaviour change, so the existing suite is unchanged.