Skip to content

Small general fixes - #596

Merged
yguclu merged 33 commits into
develfrom
small_general_fixes
Oct 13, 2026
Merged

yguclu merged 33 commits into
develfrom
small_general_fixes

Conversation

@e-moral-sanchez

@e-moral-sanchez e-moral-sanchez commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Apply several small fixes across the library.

B-spline functions

Fix exit condition (using strict inequality) in kernel function cell_index_p when tolerance is small. This allows exporting to VTK with a prescribed grid containing exact domain bounds. More systematic use of tolerances will be applied in the future (see issue #627).

Linear algebra

  • Add out argument to array_to_psydac: allow passing a PSYDAC vector to avoid allocating new memory.
  • Add out argument to vec_topetsc: allow passing a PETSc.Vec object to avoid allocating new memory.
  • Implement topetsc method for ZeroOperator. This also allows calling the method topetsc of a BlockLinearOperator containing ZeroOperator blocks.
  • Make sure that BlockLinearOperator does not call on each block update_ghost_regions, exchange_assembly_data, remove_spurious_entries when the method does not exist (for example in case of a ZeroOperator). This error did not occur before because the zero blocks are normally just stored as None, but both possibilities should be supported.

Finite element exterior calculus

Allow using global geometric projectors with complex dtype.

@codacy-production

codacy-production Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 20 complexity · 17 duplication

Metric Results
Complexity 20
Duplication 17

View in Codacy

🟢 Coverage 34.95% diff coverage · -0.09% coverage variation

Metric Results
Coverage variation ✅ -0.09% coverage variation
Diff coverage ✅ 34.95% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f2da0cd) 51844 33084 63.81%
Head commit (24bc46e) 103924 (+52080) 66220 (+33136) 63.72% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#596) 186 65 34.95%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@e-moral-sanchez
e-moral-sanchez marked this pull request as ready for review September 8, 2026 14:37
@e-moral-sanchez
e-moral-sanchez marked this pull request as draft September 9, 2026 09:24
@e-moral-sanchez
e-moral-sanchez marked this pull request as ready for review September 9, 2026 09:24
@yguclu yguclu added bug Something isn't working Next Release Must be in next release labels Sep 9, 2026
@e-moral-sanchez
e-moral-sanchez marked this pull request as draft September 9, 2026 13:11
@e-moral-sanchez e-moral-sanchez changed the title Small general fixes [NOT READY] Small general fixes Sep 18, 2026
@e-moral-sanchez
e-moral-sanchez marked this pull request as ready for review September 18, 2026 14:48
@e-moral-sanchez
e-moral-sanchez marked this pull request as draft September 21, 2026 08:38
@e-moral-sanchez
e-moral-sanchez marked this pull request as ready for review September 21, 2026 08:38
@e-moral-sanchez
e-moral-sanchez marked this pull request as draft October 12, 2026 14:43
@e-moral-sanchez
e-moral-sanchez marked this pull request as ready for review October 12, 2026 14:43
@e-moral-sanchez
e-moral-sanchez marked this pull request as draft October 12, 2026 15:32
@e-moral-sanchez
e-moral-sanchez marked this pull request as ready for review October 12, 2026 15:32

@yguclu yguclu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! One last small request

Comment thread psydac/linalg/topetsc.py Outdated
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
@yguclu
yguclu marked this pull request as draft October 13, 2026 09:50
@yguclu
yguclu marked this pull request as ready for review October 13, 2026 09:50

@yguclu yguclu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, before merging I forgot that we should update the CHANGELOG.md file, under the "Unreleased" section

@e-moral-sanchez

Copy link
Copy Markdown
Contributor Author

I added the changes in the changelog in 08cf604

Comment thread CHANGELOG.md Outdated
@yguclu
yguclu marked this pull request as draft October 13, 2026 11:40
@yguclu
yguclu marked this pull request as ready for review October 13, 2026 11:40
@yguclu
yguclu enabled auto-merge (squash) October 13, 2026 12:33
@yguclu
yguclu merged commit daec6f7 into devel Oct 13, 2026
10 checks passed
@yguclu
yguclu deleted the small_general_fixes branch October 13, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Next Release Must be in next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants