Repository navigation
Small general fixes - #596
Conversation
…urious_entries when the method does not exist
…right bound of the domain
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 20 |
| Duplication | 17 |
🟢 Coverage 34.95% diff coverage · -0.09% coverage variation
Metric Results Coverage variation ✅ -0.09% coverage variation Diff coverage ✅ 34.95% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f2da0cd) 51844 33084 63.81% Head commit (24bc46e) 103924 (+52080) 66220 (+33136) 63.72% (-0.09%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#596) 186 65 34.95% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
…mall_general_fixes
yguclu
left a comment
There was a problem hiding this comment.
Almost there! One last small request
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
yguclu
left a comment
There was a problem hiding this comment.
Sorry, before merging I forgot that we should update the CHANGELOG.md file, under the "Unreleased" section
|
I added the changes in the changelog in 08cf604 |
Apply several small fixes across the library.
B-spline functions
Fix exit condition (using strict inequality) in kernel function
cell_index_pwhen tolerance is small. This allows exporting to VTK with a prescribed grid containing exact domain bounds. More systematic use of tolerances will be applied in the future (see issue #627).Linear algebra
outargument toarray_to_psydac: allow passing a PSYDAC vector to avoid allocating new memory.outargument tovec_topetsc: allow passing aPETSc.Vecobject to avoid allocating new memory.topetscmethod forZeroOperator. This also allows calling the methodtopetscof aBlockLinearOperatorcontainingZeroOperatorblocks.BlockLinearOperatordoes not call on each blockupdate_ghost_regions,exchange_assembly_data,remove_spurious_entrieswhen the method does not exist (for example in case of aZeroOperator). This error did not occur before because the zero blocks are normally just stored asNone, but both possibilities should be supported.Finite element exterior calculus
Allow using global geometric projectors with complex
dtype.